[wp-trac] [WordPress Trac] #48396: Disabled primary button not readable outside the default admin color scheme

WordPress Trac noreply at wordpress.org
Tue Oct 22 17:51:56 UTC 2019


#48396: Disabled primary button not readable outside the default admin color scheme
---------------------------------------+--------------------------------
 Reporter:  david.binda                |       Owner:  audrasjb
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.3.1
Component:  Administration             |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, accessibility
---------------------------------------+--------------------------------
Changes (by afercia):

 * keywords:  needs-patch => has-patch has-screenshots


Comment:

 This changed in in [46241] see #34904.

 Though the disabled buttons contrast for alternate schemes isn't great in
 WordPress 5.2 and previous versions as well, I wouldn't be opposed to
 revert the change to the background color, preserving the new "flat" style
 of the buttons.

 [attachment:"48396.diff"] does that and [attachment:"48396-for-
 testing.diff"] can be used for testing in the "Profile" page, where it
 adds a couple buttons right underneath the alternate color schemes
 selection.

 Worth noting this was reported also by @johnjamesjacoby and is in the to-
 do list of adjustments to implement for the next minor release. However,
 since it's a two lines change and basically reverts to the previous
 styling, I'd like to propose to commit this now in 5.3. /Cc @audrasjb

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48396#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list