[wp-trac] [WordPress Trac] #48249: Check for int instead of null in new submenu priority implementation

[WordPress Trac]

#48249: Check for int instead of null in new submenu priority implementation
-------------------------------------------------+-------------------------
 Reporter:  david.binda                          |       Owner:  desrosj
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.3
Component:  Administration                       |     Version:  trunk
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch commit dev-reviewed i18n-  |     Focuses:
  change                                         |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"46570" 46570]:
 {{{
 #!CommitTicketReference repository="" revision="46570"
 Administration: Relax the default value check for the `$position` argument
 added to `add_submenu_page()` and related functions in [46197].

 Due to a confusion with `add_menu_page()`, which takes the `$icon_url`
 parameter, while `add_submenu_page()` does not, some plugins were passing
 in a string instead of integer as `$position`, causing backward
 compatibility issues.

 A `_doing_it_wrong()` message is now added to alert developers of the
 wrong parameter type.

 Props david.binda, desrosj, 123host, dennis_f, MattyRob.
 Reviewed by desrosj.
 Fixes #48249.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48249#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform