[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
-------------------------------------------+----------------------------
 Reporter:  karmatosed                     |       Owner:  johnbillion
     Type:  task (blessed)                 |      Status:  reviewing
 Priority:  normal                         |   Milestone:  5.3
Component:  Help/About                     |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch dev-feedback commit  |     Focuses:  accessibility
-------------------------------------------+----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch dev-feedback => has-patch dev-feedback commit


Comment:

 Thanks for catching the `aria-current` issue, @audrasjb!

 Replying to [comment:51 ryelle]:
 > I was following the [https://developer.wordpress.org/block-
 editor/contributors/develop/coding-guidelines/ Gutenberg css style,] I
 didn't realize it doesn't match the core standards. That said, I'm going
 to argue for an exception for About

 Thanks for the reasoning, makes sense to me :)

 In [attachment:"47708.8.diff"]:
 * Remove the `aria-label` attribute, per comment:50.
 * Keep the class names as is, per comment:51.

 Should be good to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform