[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
-------------------------------------------+----------------------------
 Reporter:  karmatosed                     |       Owner:  johnbillion
     Type:  task (blessed)                 |      Status:  reviewing
 Priority:  normal                         |   Milestone:  5.3
Component:  Help/About                     |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch commit dev-feedback  |     Focuses:  accessibility
-------------------------------------------+----------------------------

Comment (by ryelle):

 Replying to [comment:42 SergeyBiryukov]:
 > I agree we should not violate our own coding standards :)

 I was following the [https://developer.wordpress.org/block-
 editor/contributors/develop/coding-guidelines/ Gutenberg css style,] I
 didn't realize it doesn't match the core standards. That said, I'm going
 to argue for an exception for About:

 - The new classes avoid any style bleed (either from other pages or into
 other pages). This about design is so different visually from the rest of
 wp-admin, and probably will continue to be different- **we'll want classes
 that aren't used anywhere else.**
 - We have the ability to create a new "design system" for the about pages-
 **we should try to create a consistent naming pattern.**
 - The BEM-style is already used in the editor, and the double-underscores
 are a way of separating out `[section]__[item]` in a more readable way.

 IMO, this use of underscores is a different kind of use than what's
 described in the core coding standards, where classes are more like just
 item names, rather than scoped to a section. Underscores are still not
 used in the `item` part of the class, they only show up as double-
 underscore separators.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform