[wp-trac] [WordPress Trac] #48249: Check for int instead of null in new submenu priority implementation

WordPress Trac noreply at wordpress.org
Mon Oct 21 21:02:08 UTC 2019


#48249: Check for int instead of null in new submenu priority implementation
-------------------------------------------+------------------------
 Reporter:  david.binda                    |       Owner:  audrasjb
     Type:  defect (bug)                   |      Status:  reviewing
 Priority:  normal                         |   Milestone:  5.3
Component:  Menus                          |     Version:  trunk
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch commit dev-reviewed  |     Focuses:
-------------------------------------------+------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:11 desrosj]:
 > However, I am wondering if a `_doing_it_wrong()` should be added here.
 This may not be possible to add for 5.3 (since we are in string freeze),
 but a follow up ticket could be created for 5.3.1.

 Yes, this seems like a perfect use case for a `_doing_it_wrong()` message.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48249#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list