[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
----------------------------+----------------------------
 Reporter:  karmatosed      |       Owner:  johnbillion
     Type:  task (blessed)  |      Status:  reviewing
 Priority:  normal          |   Milestone:  5.3
Component:  Help/About      |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  accessibility
----------------------------+----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:28 afercia]:
 > Quickly looking at [attachment:"47708.diff"] I see that some CSS
 selectors use underscores. According to the
 [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/css/#selectors WordPress CSS coding standards], selectors
 should:
 > > use lowercase and separate words with hyphens when naming selectors.
 Avoid camelcase and underscores.

 I agree we should not violate our own coding standards :)

 List of new classes added in [46556] that should probably be corrected to
 match the coding standards:

 * `about__header`
 * `about__header-title`
 * `about__header-badge` (could reuse `wp-badge`?)
 * `about__header-text` (could reuse `about-text`?)
 * `about__header-navigation` (could reuse `nav-tab-wrapper`?)
 * `about__section` (could reuse `feature-section`?)
 * `about__image`

 Some of the classes look like they could reuse some existing classes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform