[wp-trac] [WordPress Trac] #48363: Empty string in database for boolean meta not cast to false

[WordPress Trac]

#48363: Empty string in database for boolean meta not cast to false
---------------------------------------------+-------------------------
 Reporter:  chrisvanpatten                   |       Owner:  kadamwhite
     Type:  defect (bug)                     |      Status:  assigned
 Priority:  normal                           |   Milestone:  5.3
Component:  REST API                         |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  has-unit-tests has-patch commit  |     Focuses:  rest-api
---------------------------------------------+-------------------------
Changes (by rmccue):

 * keywords:  has-unit-tests has-patch dev-feedback commit => has-unit-tests
     has-patch commit


Comment:

 KAdam pinged me for a `dev-feedback` review on [attachment:"48363.3.diff"]
 so notes below:

 Using `self::` makes it impossible to subclass. This should either use
 `static::` (5.3+; assuming this is allowed in the coding standards now?)
 or `$this->` (which can be used on static methods).

 Otherwise, patch looks good to me, r+.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48363#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform