[wp-trac] [WordPress Trac] #48249: Check for int instead of null in new submenu priority implementation

WordPress Trac noreply at wordpress.org
Sat Oct 19 00:46:04 UTC 2019


#48249: Check for int instead of null in new submenu priority implementation
-------------------------------------------+------------------------
 Reporter:  david.binda                    |       Owner:  audrasjb
     Type:  defect (bug)                   |      Status:  reviewing
 Priority:  normal                         |   Milestone:  5.3
Component:  Menus                          |     Version:  trunk
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch commit dev-feedback  |     Focuses:
-------------------------------------------+------------------------
Changes (by SergeyBiryukov):

 * keywords:   => has-patch commit dev-feedback
 * milestone:  Future Release => 5.3


Comment:

 Note that the issue is also reported on the original ticket, #39776, in
 comment:33:ticket:39776.

 Passing extra arguments to `add_submenu_page()` might technically be a
 developer error, but since this is a regression that can cause default
 WordPress submenu items to disappear (as noted above), moving back to
 handle in 5.3 RC2.

 The patch looks good to me, marking for a second committer's review.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48249#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list