[wp-trac] [WordPress Trac] #48312: PHP4 notation for passing object by reference broken

[WordPress Trac]

#48312: PHP4 notation for passing object by reference broken
--------------------------+---------------------
 Reporter:  david.binda   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.3
Component:  Plugins       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+---------------------

Comment (by SergeyBiryukov):

 Replying to [ticket:48312 david.binda]:
 > It's true that in PHP 5 all objects are being passed as references, so
 the array wrapping is no longer needed, but in case there is a code using
 the old notation (see above), the args are not really being passed to the
 callback in an expected way, eventually producing issues in the callbacks.

 Thanks for bringing this up! Has this come up in a project with some
 legacy code?

 I haven't seen any other reports in the 4 weeks since [46149] was
 committed, however maybe it would be safer to revert [46149] for now and
 re-commit early in 5.4 to allow for more testing and feedback?

 @jrf, what do you think?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48312#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform