[wp-trac] [WordPress Trac] #40439: Save progress of intermediate image creation after upload

WordPress Trac noreply at wordpress.org
Mon Oct 14 19:00:19 UTC 2019


#40439: Save progress of intermediate image creation after upload
---------------------------------------------+---------------------------
 Reporter:  mikeschroder                     |       Owner:  mikeschroder
     Type:  enhancement                      |      Status:  reopened
 Priority:  high                             |   Milestone:  5.3
Component:  Media                            |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  needs-unit-tests needs-dev-note  |     Focuses:  ui
---------------------------------------------+---------------------------

Comment (by azaozz):

 Replying to [comment:67 mikeschroder]:
 > I don't want to lose the ability to tell what might be causing errors or
 users, but tend to agree that WordPress should be using data it logs.

 Yeah, that's exactly what I'm thinking.

 > As another option, we could choose to save information on errors only
 when `WP_DEBUG` is enabled for this release.

 Think that saving error messages in image meta wasn't a good idea. Seemed
 good at the time but not so good now :)

 The idea was to be able to show these errors in the UI. As post-processing
 of images is always async, the errors (including the messages) would need
 to be stored "somewhere". That could also be a transient (to make cleanup
 easier).

 Ideally these errors should be logged to an appropriate place. They can be
 hard to understand and are valuable mostly for (low level) debugging,
 perhaps not so much to show to users. Thinking this would fit better in
 the "Site Health" context. Also ideally we should be logging all errors
 encountered while trying to edit image files (all the TODOs). Currently
 all of the errors are logged in the server error logs, but would be nice
 to be able to access them from WP.

 Thinking to commit 40439.5.diff as it fixes the "persistent data not used
 anywhere" problem. If you think we should add transients to store them, we
 still have time to do that before RC tomorrow :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40439#comment:68>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list