[wp-trac] [WordPress Trac] #47138: Visible labelling only done via placeholder attribute

[WordPress Trac]

#47138: Visible labelling only done via placeholder attribute
-------------------------------------------------+-------------------------
 Reporter:  anevins                              |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.3
Component:  Media                                |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-screenshots wpcampus-report      |     Focuses:  ui,
  form-controls has-patch                        |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots wpcampus-report form-controls needs-patch =>
     has-screenshots wpcampus-report form-controls has-patch


Comment:

 On a fast network and with powerful hardware the spinner may not appear at
 all. That's because it appears only after a brief delay and if the
 attachments fetch is fast enough, the spinner is not displayed.

 To test, the easier way is to throttle the network speed to "Slow 3G" from
 the Chrome dev tools > Network tab.

 [46418] added `float: none` to the spinner CSS. This works in most of the
 cases in the main views. The problem the latest patch
 [attachment:"47138.5.diff"] seeks to solve is that while normally the
 spinner is the last item in the toolbar, in other views there are other
 elements before it. For example when there are "instructions" for the
 image dimensions or the drag and drop instructions. See screenshots
 attached below.

 In these cases, whether the spinner appears or not, it still takes space
 and the text is shifted to the right.

 Seems to me the easiest solution is making the spinner always be the last
 element within the toolbar.

 Some testing would be nice :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47138#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform