[wp-trac] [WordPress Trac] #47149: Tab structure does not use tab semantics
WordPress Trac
noreply at wordpress.org
Fri Oct 11 09:25:39 UTC 2019
#47149: Tab structure does not use tab semantics
-------------------------------------+-------------------------------------
Reporter: anevins | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.3
Component: Media | Version:
Severity: normal | Resolution:
Keywords: needs-post-mortem | Focuses: accessibility,
wpcampus-report has-screenshots | javascript
semantic-buttons has-patch |
-------------------------------------+-------------------------------------
Changes (by afercia):
* type: enhancement => defect (bug)
Comment:
@azaozz thanks for sharing your concerns.
> Re: process, this ticket was supposed to be a bug fix to change some
links into buttons
Not exactly. The actual point here is that the visual presentation looks
like "tabs" but they weren't real tabs, not providing the expected
semantics and interaction of [https://www.w3.org/TR/wai-aria-
practices-1.1/#tabpanel the ARIA tabs pattern]. Also reported by the
WPCampus audit as "medium" severity, ie: not a minor thing. As such, this
was a bug.
> but has turned into an "arbitrary enhancement" for the media modal
instead. Being an enhancement, it shouldn't have been committed during
beta.
Being a bug, it can be committed at any time during beta.
Not sure what do you mean by "arbitrary enhancement". The change to ARIA
tabs implied other changes including CSS especially for the mobile part.
Please notice the patch for this ticket was ready since weeks. See
comment:34. Design feedback was a bit late and I had to wait for their
feedback, That's why I opted to commit the patch and change this ticket
from "bug" to "task (blessed)" to give design the time for feedback and
iterate. See comment:51.
> the "Media Types" label/heading is confusing and degrades user
experience (even if changed to "Actions"). What does "media types" have to
do with "cancel gallery", and why would the menu need a separate title?
The modal already has a title, in this case it's "Create Gallery", that
states the purpose a lot better.
There are two different things here:
- the "Media Types" heading pertains to #47610 see there for the good
reasons to add more headings within the modal
- the "Media Types" toggle button that appears in the responsive view to
toggle the menu: this is a button and needs to identify the available
action. As in "what happens when I click this button". "Create Gallery"
(or similar) is not a proper text for this button simply because when you
click the button it doesn't create a gallery :) It opens the menu. Also,
initially the button text was "Menu": simple and effective. It was changed
to "Media Types" after design feedback. see comment:41.
Re: the wording, I'd agree it needs to be improved for both the heading
and the button. This was noted on this ticket and also on #47610. The
current proposed text are the following ones. Please just let me know
which one is preferred, I haven't got a final feedback so far.
- Settings
- Actions
- More...
- Manage media
- Manage
- Menu
For the button, personally I'd lean towards "Menu" because that's what the
button does: it opens and closes the menu.
For the heading, it needs to identify what that section of the media modal
is about. I'd lean towards "Manage media" but this should be discussed on
#47610.
That said, I'd like to change this ticket back to "bug" because it's a bug
not an enhancement.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47149#comment:68>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list