[wp-trac] [WordPress Trac] #47477: Content overflows and is cut off at 200% text enlarge

[WordPress Trac]

#47477: Content overflows and is cut off at 200% text enlarge
-------------------------------------------------+-------------------------
 Reporter:  kjellr                               |       Owner:  audrasjb
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  high                                 |   Milestone:  5.3
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-post-mortem has-screenshots    |     Focuses:
  wpcampus-report has-patch 5-3-admin-css-       |  accessibility
  changes                                        |
-------------------------------------------------+-------------------------

Comment (by afercia):

 @azaozz thanks for clarifying.

 > The main problem is we are out of time

 The first set of changes on this ticket was committed on `09/23/2019
 04:26:24 PM` (see comment 22) which, technically, is before Beta 1 :) Just
 to clarify a process detail. Please allow me to say that maybe feedback
 from other teams came a bit out of time.

 Regarding your points, referring to the screenshot you posted:

 [[Image(http://cldup.com/wUheyxjVub.png)]]

 **Vertically slightly off-center.**
 I see it and I know. But please look at the previous inconsistencies,
 which are way worse. I wouldn't say the previous select and inputs are
 nicely aligned: these inconsistencies are all over the place in WordPress
 5.2 and all previous versions as there's really no standard height for the
 form controls. Instead, I'd say the current style is an improvement.
 Anyways, I commented previously on
 https://core.trac.wordpress.org/ticket/34904#comment:109 that this just
 needs a decision. Given the CSS is now way simpler, we can easily
 standardize the default height of all controls: inputs, selects, buttons
 to 28px or 30px. Just needs a decision. I haven't got any constructive
 feedback yet, though.

 Also, as I previously commented, there are design plans for the future to
 use a "standard grid" probably based on 8 pixels and it's very likely all
 form controls will have an even bigger height: 32 pixels on desktop for
 the normal size and 40 pixels on mobile.

 Also, as I said previously, the text alignment on Windows is a "system
 fonts" issue. The only way to solve it reliably is to change the font
 stack removing "Segoe UI".  Please notice this text alignment issue on
 Windows is clearly visible on WordPress 5.2 and all previous versions.

 **Arrows off-center.**
 Honestly, I don't see the arrows are off-center.

 **Height is different/doesn't match.**
 See above: just needs a decision and, regardless, this is a pre-existing
 issue clearly visible all over the place on WordPress 5.2 and all previous
 versions.

 **Font-weight is different/doesn't match.**
 Not sure I follow. Maybe the different font weight of "Filter Media" and
 "Search"? The former is a heading, the latter is a `<label>` element so
 they have a native different weight. Not sure this is a serious breakage
 :) Not a regression, as these are new in 5.3.

 **Width different (will affect translated strings).**
 Not sure I follow. The selects maybe? Their width is determined by the
 longest `<option>` element within them so they will adjust their width
 with longer translations. Regardless, all the "float-drops" and breakages
 that happen in WordPress 5.2 and all previous versions will still happen
 in 5.3. On this regard, I think we agree the toolbar CSS is far from ideal
 and would need a substantial refactoring. This issue exists since...
 forever.

 In all honesty, I don't see how all this can justify a revert. If there
 are other serious reasons to consider a revert, I'd be happy to be
 informed to better consider the best path forward.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47477#comment:65>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform