[wp-trac] [WordPress Trac] #47948: Twenty Eleven: circle mask image blocks are cut off
WordPress Trac
noreply at wordpress.org
Thu Oct 10 16:14:11 UTC 2019
#47948: Twenty Eleven: circle mask image blocks are cut off
-------------------------------------------------+-------------------------
Reporter: desrosj | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future
| Release
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: good-first-bug has-screenshots has- | Focuses:
patch needs-testing |
-------------------------------------------------+-------------------------
Comment (by sabernhardt):
@progremzion Thanks for the patch (congratulations on your first one)! For
your next patch, you can (usually) remove the units for zero values.
https://make.wordpress.org/core/handbook/best-practices/coding-
standards/css/
After that patch removes the padding, it's still slightly off because of
the one-pixel border. So I set the border to 0 as well and applied the
same styles for the post editor screen.
I also noticed a problem with `mask-size: contain` on rectangular images
in the Edge browser. This probably should be fixed elsewhere instead, but
I added an Edge-specific condition here to give these images the same pill
shape that was deemed acceptable for Internet Explorer.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47948#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list