[wp-trac] [WordPress Trac] #48249: Check for int instead of null in new submenu priority implementation

WordPress Trac noreply at wordpress.org
Wed Oct 9 08:54:15 UTC 2019


#48249: Check for int instead of null in new submenu priority implementation
--------------------------+-----------------------------
 Reporter:  david.binda   |       Owner:  audrasjb
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  Future Release
Component:  Menus         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------------

Comment (by 123host):

 Thanks so much @davidbinda, had it not been for the fact that you happened
 to use my plugin as an example and the matcher alerted me, I would never
 have been aware of this.

 I notice at
 https://developer.wordpress.org/reference/functions/add_submenu_page/ that
 the 6th parameter is an optional callable function.  Am I right in
 assuming that since I had `$petitions['icon_url']` that is what would have
 thrown the warning.

 But this is in 5.3, right?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48249#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list