[wp-trac] [WordPress Trac] #42201: Admin Sidebar Text length Issue

[WordPress Trac]

#42201: Admin Sidebar Text length Issue
-----------------------------------------+-----------------------
 Reporter:  jagirbaheshwp                |       Owner:  audrasjb
     Type:  defect (bug)                 |      Status:  reopened
 Priority:  normal                       |   Milestone:  5.3
Component:  Administration               |     Version:  4.8.2
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:  ui
-----------------------------------------+-----------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch commit => has-screenshots needs-
               patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Sorry to reopen but [46453] doesn't seem to fully address the unnecessary
 visual changes introduced with the previous commit.

 1
 On WordPress 5.2 when the counters have only 1 digit, they're a 18 by 18
 pixels circle. This is not a coincidence: it's intentional and the CSS
 should make sure it's a perfect circle. Instead, now the counters aren't a
 perfect circle: they have a slightly oval shape and the number is not
 perfectly centered. Screenshot:

 [[Image(http://cldup.com/k2JO9FcvIt.png)]]

 2
 The spacing between the text and the counters is still clearly different
 and doesn't help readability. Not to mention it's not great visually.

 3
 With longer menu items or longer translations the counter ends up in the
 middle of the page: this is undesirable. On WordPress 5.2 wasn't perfect
 as well but at least it went to a new line leaving just the text to
 overflow into the page.

 Screenshot for 2 and 3:

 [[Image(http://cldup.com/zbBRKZgyBH.png)]]

 4
 `#adminmenu .wp-menu-name > span` is now a flex item thus these properties
 applied on it:

 {{{
 display: inline-block;
 vertical-align: top;
 }}}

 don't make much sense. Alignment should be controlled with the properties
 that pertain to flexbox.

 See also the attached animated GIF that better highlights the visual
 changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42201#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform