[wp-trac] [WordPress Trac] #47138: Visible labelling only done via placeholder attribute

[WordPress Trac]

#47138: Visible labelling only done via placeholder attribute
-------------------------------------------------+-------------------------
 Reporter:  anevins                              |       Owner:  audrasjb
     Type:  task (blessed)                       |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.3
Component:  Media                                |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-screenshots wpcampus-report      |     Focuses:  ui,
  form-controls has-patch commit                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:22 afercia]:
 > Not sure we should remove the existing strings `searchMediaLabel` and
 `searchMediaPlaceholder`: there's a chance plugins are using them for any
 custom things they add to the media views. I'd rather introduce a new
 string.

 In the plugin directory, there are
 [https://wpdirectory.net/search/01DPFCDW793QD1S3NAGXFTQZCR 3 matches for
 searchMediaLabel] and
 [https://wpdirectory.net/search/01DPFCJQKNEJ81TFAC7KRDW0J5 1 match for
 searchMediaPlaceholder], though only
 [https://plugins.trac.wordpress.org/browser/enhanced-media-
 library/tags/2.7.2/js/eml-media-views.js?marks=973#L970 Enhanced Media
 Library] appears to be affected.

 If we're keeping the strings, then the `// placeholder (no ellipsis)`
 comment should also be kept, as per [34233].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47138#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform