[wp-trac] [WordPress Trac] #34290: Not possible to have a percent symbol contained in the default value of a theme_mod
WordPress Trac
noreply at wordpress.org
Sat Oct 5 00:53:51 UTC 2019
#34290: Not possible to have a percent symbol contained in the default value of a
theme_mod
-------------------------------------+-------------------------------------
Reporter: kuus | Owner: SergeyBiryukov
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 5.3
Component: Customize | Version: 4.4
Severity: normal | Resolution: fixed
Keywords: has-patch needs-unit- | Focuses: javascript,
tests | administration
-------------------------------------+-------------------------------------
Changes (by SergeyBiryukov):
* status: accepted => closed
* resolution: => fixed
Comment:
In [changeset:"46395" 46395]:
{{{
#!CommitTicketReference repository="" revision="46395"
Themes: In `get_theme_mod()`, only run the `sprintf()` replacement on the
default value if there's a string format pattern found in the value.
This prevents standalone percent symbols from being stripped out, e.g. in
a default value like `100%`.
Props aristath, kuus, moonomo, westonruter, davetgreen, daviedR, katielgc,
noisysocks, SergeyBiryukov.
Fixes #34290.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34290#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list