[wp-trac] [WordPress Trac] #48210: I18n: consistent strings variables across admin and network sub-projects

[WordPress Trac]

#48210: I18n: consistent strings variables across admin and network sub-projects
-------------------------------------+------------------------
 Reporter:  pedromendonca            |       Owner:  ocean90
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  5.3
Component:  I18N                     |     Version:  trunk
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-refresh  |     Focuses:  multisite
-------------------------------------+------------------------

Comment (by ocean90):

 Replying to [comment:2 pedromendonca]:
 > I've added the contexts and the translator comments as suggested

 Thanks! In [46385] I only committed the changes to the sites table. The
 context is only necessary if we use the same string in different contexts.

 Replying to [comment:3 garrett-eclipse]:
 > My one question is `_nx` vs `_nx_noop` as I noticed it's a mix of the
 two functions throughout core for these count strings.

 `_nx_noop()` is a no-operation function and only used to register a string
 if you don't have the number yet. Once you have the number you can
 translate the string with `translate_nooped_plural()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48210#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform