[wp-trac] [WordPress Trac] #37392: Multisite "Sites" screen: Add links to filter websites by status
WordPress Trac
noreply at wordpress.org
Fri Oct 4 05:11:01 UTC 2019
#37392: Multisite "Sites" screen: Add links to filter websites by status
--------------------------------------+------------------------
Reporter: thomaswm | Owner: mnelson4
Type: enhancement | Status: reopened
Priority: normal | Milestone: 5.3
Component: Networks and Sites | Version: 3.0
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses: multisite
--------------------------------------+------------------------
Changes (by garrett-eclipse):
* status: closed => reopened
* resolution: fixed =>
Comment:
Hello, sorry to re-open this, let me know if a new ticket is better.
While translating the new strings I found there's a mix of placeholders in
the $statuses array here;
https://github.com/WordPress/wordpress-develop/blob/master/src/wp-
admin/includes/class-wp-ms-sites-list-table.php#L221-L228
Specifically the singular for All and Public use the `%s` placeholder
while all others use `%1$s`.
This was introduced in [https://core.trac.wordpress.org/changeset/46254
Changeset#46254]
From the docs on `_n_noop` I believe all of the placeholders there should
use `%s` notation.
https://developer.wordpress.org/reference/functions/_n_noop/
https://codex.wordpress.org/Function_Reference/_n_noop
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37392#comment:62>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list