[wp-trac] [WordPress Trac] #48202: Media: rotation of JPEG files may fail

[WordPress Trac]

#48202: Media: rotation of JPEG files may fail
-----------------------------------------+---------------------
 Reporter:  azaozz                       |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  high                         |   Milestone:  5.3
Component:  Media                        |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |     Focuses:
-----------------------------------------+---------------------

Comment (by tmatsuur):

 Replying to [comment:3 azaozz]:
 > In 48202.diff:
 > - Use `imagecolorallocate()` instead of `imagecolorallocatealpha()` when
 rotating JPEGs.
 > - Do not set `imagealphablending()` and `imagesavealpha()` for JPEGs.
 >
 > Testing here with PHP 7.3, this patch doesn't make any difference.
 Rotated PNGs are tansparent, GIFs are ...not really. JPEGs work as
 expected.
 >
 > @tmatsuur can you test (the sooner -- the better) if that fixes it for
 you?
 Thanks @azaozz

 As you pointed out, it was wrong to specify GIF as a condition in an if
 statement.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48202#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform