[wp-trac] [WordPress Trac] #42990: Deprecate WP_UnitTestCase::_make_attachment

[WordPress Trac]

#42990: Deprecate WP_UnitTestCase::_make_attachment
-------------------------------------+-----------------------------
 Reporter:  Frank Klein              |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Build/Test Tools         |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:  has-patch => has-patch needs-refresh
 * milestone:  Awaiting Review => Future Release


Comment:

 Hi @frank-klein,

 Thanks for this one! Sorry it took so long to receive a response.

 Thinking this through, I think it would be best to ensure
 `create_upload_object` is used consistently in Core as a first step and
 then consider deprecating `WP_UnitTestCase::_make_attachment`.

 I also just went to apply [attachment:"42990.patch"] for testing, but it
 appears to need a refresh.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42990#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform