[wp-trac] [WordPress Trac] #47138: Visible labelling only done via placeholder attribute

[WordPress Trac]

#47138: Visible labelling only done via placeholder attribute
-------------------------------------------------+-------------------------
 Reporter:  anevins                              |       Owner:  audrasjb
     Type:  task (blessed)                       |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.3
Component:  Media                                |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-screenshots wpcampus-report      |     Focuses:  ui,
  form-controls has-patch commit                 |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots wpcampus-report form-controls needs-patch =>
     has-screenshots wpcampus-report form-controls has-patch commit


Comment:

 [attachment:"47138.2.diff"] refreshes the patch:
 - uses flexbox only for the search form
 - keeps the old strings, adds a new one
 - in the media modal: the visible label is now ''above'' the input field:
 this way, it doesn't alter in any way the existing widths / floats, in teh
 responsive view all the existings drop-float and breakages are unchanged
 :)
 - in the media library (the grid mode): flexbox helps a bit: even if the
 label is horizontally aligned and reduces the available space for the form
 controls, the responsiveness is basically unchanged

 Looks good to me, I'd greatly appreciate a final review.

 Screenshots attached below.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47138#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform