[wp-trac] [WordPress Trac] #48126: Twenty Nineteen: Duplicate <h1> tags

[WordPress Trac]

#48126: Twenty Nineteen: Duplicate <h1> tags
---------------------------+------------------------------
 Reporter:  williampatton  |       Owner:  adamsilverstein
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:  worksforme
 Keywords:  has-patch      |     Focuses:  accessibility
---------------------------+------------------------------
Changes (by adamsilverstein):

 * status:  assigned => closed
 * resolution:   => worksforme
 * milestone:  5.3 =>


Comment:

 After reviewing the changes here more carefully, I agree with @sabernhardt
 - I don't think we need to change anything here.

 The reason twentytwenty needed the change is its comparison used
 `is_front_page() || is_home()`. In `twentynineteen` and previous themes
 used ` is_front_page() && is_home()`. With the logic this way, duplicate
 `h1`s do not occur as far as i can tell.

 Closing this as `worksforme`. @williampatton if I have missed something or
 you feel there is still an issue that needs fixing here, please feel free
 to reopen this ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48126#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform