[wp-trac] [WordPress Trac] #47515: i18n: Add missing translators comments
WordPress Trac
noreply at wordpress.org
Wed Oct 2 21:44:35 UTC 2019
#47515: i18n: Add missing translators comments
------------------------------+-----------------------------
Reporter: mukesh27 | Owner: SergeyBiryukov
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.3
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses: administration
------------------------------+-----------------------------
Changes (by garrett-eclipse):
* keywords: has-patch => has-patch commit
Comment:
Attempting to apply this I found most of the changes proposed in
[https://core.trac.wordpress.org/attachment/ticket/47515/47515.2.diff
47515.2.diff] were addressed by @SergeyBiryukov (and others) in commit
[https://core.trac.wordpress.org/changeset/45926 Changeset#45926].
With that said, there's still one incorrect translator comment in that it
has a single %s placeholder reference but the string holds two numbered
placeholders. I'm referring to this code;
{{{
printf(
/* translators: %s: Link to documentation on child themes. */
' <p class="howto">' . __( 'This <a href="%1$s">child theme</a>
requires its parent theme, %2$s.' ) . '</p>',
__( 'https://developer.wordpress.org/themes/advanced-topics/child-
themes/' ),
$theme->parent()->display( 'Name' )
);
}}}
Permalink - https://github.com/WordPress/wordpress-develop/blob/master/src
/wp-admin/includes/class-wp-themes-list-table.php#L283-L288
With that in mind
[https://core.trac.wordpress.org/attachment/ticket/47515/47515.3.diff
47515.3.diff] fixes this remaining comment.
Marking for `commit`, can you review @SergeyBiryukov
For easy reference the updated translator comment;
`/* translators: 1: Link to documentation on child themes 2: Name of
parent theme. */`
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47515#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list