[wp-trac] [WordPress Trac] #46776: Add missing translator comments and update about-text function usage in wp-admin/about.php

WordPress Trac noreply at wordpress.org
Wed Oct 2 21:14:59 UTC 2019


#46776: Add missing translator comments and update about-text function usage in wp-
admin/about.php
--------------------------+-----------------------------
 Reporter:  thrijith      |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Help/About    |     Version:  5.1
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:
--------------------------+-----------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch close =>
 * status:  reviewing => closed
 * resolution:   => fixed
 * milestone:  5.3 =>


Comment:

 Thanks for everyone's work on this ticket, I'm closing this as the
 verbiage has changed and the current trunk has both the proper use of the
 placeholder along with a translator comment as can be seen here;
 {{{
 <p class="about-text">
     <?php
     printf(
         /* translators: %s: The current WordPress version number. */
         __( 'Congratulations on updating to WordPress %s! This update
 makes it easier than ever to fix your site if something goes wrong.' ),
         $display_version
     );
     ?>
 </p>
 }}}
 https://github.com/WordPress/wordpress-develop/blob/master/src/wp-
 admin/about.php#L30-L38

 The text was changed for 5.2 in commit
 [https://core.trac.wordpress.org/changeset/45271 Changeset#45271], and the
 placeholder and translator comment introduced in commit
 [https://core.trac.wordpress.org/changeset/45338 Changeset#45338].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46776#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list