[wp-trac] [WordPress Trac] #47138: Visible labelling only done via placeholder attribute
WordPress Trac
noreply at wordpress.org
Tue Oct 1 22:39:53 UTC 2019
#47138: Visible labelling only done via placeholder attribute
-------------------------------------------------+-------------------------
Reporter: anevins | Owner: audrasjb
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 5.3
Component: Media | Version:
Severity: minor | Resolution:
Keywords: has-screenshots wpcampus-report | Focuses: ui,
form-controls needs-patch | accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):
* keywords: has-screenshots wpcampus-report form-controls has-patch dev-
feedback => has-screenshots wpcampus-report form-controls needs-patch
Comment:
Yep I'd agree with @azaozz that the media modal would need some
refactoring. This UI has been a bit neglected for years: fixed heights and
absolute positioning were a few years ago maybe the only option to build a
decent layout. They don't scale when adding content though, the
responsiveness is not ideal to be fair, and today there are better CSS
techniques.
Worth noting though that in #47610 I already partially refactored the
''height'' of the toolbar following the feedback provided by the design
team. That is to make room for the new headings. Changing the height
doesn't alter the widths :) and basically keeps the current responsiveness
unaltered (with all its existing bugs and breakages).
Coincidentally, now there's enough room ''above'' the search field to
place the visible label there. See the final design in the screenshots
after comment https://core.trac.wordpress.org/ticket/47610#comment:30
Seems to me this ticket needs only a quick patch refresh to adjust the CSS
and move the visible label above the search field.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47138#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list