[wp-trac] [WordPress Trac] #47559: Subtitle tracks use English as default (hardcoded) in track element srclang and label attributes

[WordPress Trac]

#47559: Subtitle tracks use English as default (hardcoded) in track element srclang
and label attributes
-------------------------------------+-------------------------------------
 Reporter:  BjornW                   |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.3
Component:  Media                    |     Version:  5.2.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch commit                       |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch dev-feedback commit => has-
     screenshots has-patch commit


Comment:

 The approach looks good to me. Reviewed a bit the patch in
 [attachment:"47559.2.diff"].

 The existing code in the media views always allowed to insert more than
 one track.

 However, the current code needs to be changed to properly generate
 multiple unique IDs needed for the label / input association. I also moved
 the description underneath the input field, as that's the convention in
 core and used an `aria-describedby` attribute to associate the description
 to the field. Shortened a bit the translatable string and used `sprint()`
 to help translators understand they don't have to translate the HTML
 attributes names.

 As agreed during today's accessibility bug scrub, this is a first step. In
 the next release cycle there's should be some focus to introduce a new
 user interface to edit the srclang, label, and kind attributes. Also, the
 same functionality needs to be introduced in Gutenberg.

 Screenshots attached below.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47559#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform