[wp-trac] [WordPress Trac] #47987: REST API: Add handling of PHP fatal errors while resizing images after upload

WordPress Trac noreply at wordpress.org
Tue Oct 1 16:58:52 UTC 2019


#47987: REST API: Add handling of PHP fatal errors while resizing images after
upload
-------------------------------------------------+-------------------------
 Reporter:  azaozz                               |       Owner:
                                                 |  TimothyBlynJacobs
     Type:  task (blessed)                       |      Status:  accepted
 Priority:  highest omg bbq                      |   Milestone:  5.3
Component:  REST API                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-unit-tests dev-      |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by TimothyBlynJacobs):

 I think that patch is following that request outline, no? Am I missing
 something?

 To test this, I inserted a `die` at the top of
 `wp_generate_attachment_metadata`. Then did the following requests


 {{{
 POST /wp-json/wp/v2/media
 X-WP-ImageRef: myreference
 Content-Type: multipart/form-data; boundary=X-INSOMNIA-BOUNDARY
 file => file
 alt_text => This is my alt
 }}}

 Then...

 {{{
 POST /wp-json/wp/v2/media
 X-WP-RetryImageRef: myreference
 Content-Type: multipart/form-data; boundary=X-INSOMNIA-BOUNDARY
 alt_text => This is my alt
 }}}

 The thing missing from the patch being clearing the upload ref after
 repeated failures.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47987#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list