[wp-trac] [WordPress Trac] #47366: Privacy Policy page dropdown needs a max-width
WordPress Trac
noreply at wordpress.org
Tue Oct 1 07:01:20 UTC 2019
#47366: Privacy Policy page dropdown needs a max-width
----------------------------------------------+----------------------------
Reporter: SergeyBiryukov | Owner: garrett-
| eclipse
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.3
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch commit | Focuses: ui, privacy
----------------------------------------------+----------------------------
Changes (by garrett-eclipse):
* keywords: good-first-bug has-screenshots has-patch => has-screenshots
has-patch commit
* owner: (none) => garrett-eclipse
* focuses: ui, administration => ui, privacy
* component: Privacy => Administration
* status: new => accepted
Comment:
Thanks @SergeyBiryukov / @mukesh27 / @desrosj / @adhitya03 /
@jalpa1984 for the patches they were very helpful in reproducing and
analyzing the options here.
I've refreshed @adhitya03 patch to apply against trunk with
[https://core.trac.wordpress.org/attachment/ticket/47366/47366.6.diff
47366.6.diff], I agree we should be 'consistent with other pages'.
Testing with the patches the `max-width: 25rem;` conformed with other
inputs across browsers and screensizes as well it never allowed the
content to overflow the page.
@paresh07 while I appreciate the feedback I feel there's no need to
truncate the actual option contents as that would interfere with
screenreaders as well on Chrome and other browsers the options will never
overflow the screen, but if you are on desktop it will overflow the
viewport outside of your browser to allow users to read the full
title/contents. I've illustrated that here -
[https://core.trac.wordpress.org/attachment/ticket/47366/Screen%20Shot%202019-09-30%20at%2011.27.41%20PM.png
screenshot]
Testing across browsers and through the multiple admin screens, this
addresses the issues on Privacy and Reading Settings without causing
reversion in other areas.
@SergeyBiryukov / @desrosj this is ready for a final committers review.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47366#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list