[wp-trac] [WordPress Trac] #36640: Customize: get_custom_logo should allow the image tag to be filtered independently

[WordPress Trac]

#36640: Customize: get_custom_logo should allow the image tag to be filtered
independently
-------------------------+---------------------
 Reporter:  achbed       |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  5.4
Component:  Customize    |     Version:  4.5
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+---------------------
Changes (by dlh):

 * milestone:   => 5.4


Comment:

 [45028] removed `itemprop` from the default custom logo attributes. The
 `get_custom_logo` and `wp_get_attachment_image_attributes` filters were
 suggested as options for restoring `itemprop`, and while those certainly
 work, the filter suggested here would arguably make the process a little
 less cumbersome.

 [attachment:"36640.diff"] refreshes the previous patch with a couple
 changes:

 - Rename the filter to `get_custom_logo_image_attributes` for consistency
 with `wp_get_attachment_image_attributes`.

 - Move the attachment ID to the second filter parameter under the
 assumption that it'll be more common to need that ID than the current blog
 ID.

 As highlighted in comment:2, the `custom-logo-link` class should still be
 unaffected by the filter.

 I'll check in with #core-themes for other opinions, and maybe there can be
 a yea or nay on this enhancement during the 5.4 cycle.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36640#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform