[wp-trac] [WordPress Trac] #42140: Incorrect use of plural in class-wp-customize-themes-section.php
WordPress Trac
noreply at wordpress.org
Fri Nov 29 20:42:29 UTC 2019
#42140: Incorrect use of plural in class-wp-customize-themes-section.php
--------------------------+-------------------------
Reporter: tobifjellner | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.4
Component: Customize | Version: 4.9
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript
--------------------------+-------------------------
Changes (by dlh):
* keywords: needs-patch => has-patch
* milestone: Future Release => 5.4
Comment:
I think this string can now be translated with `wp.i18n._n()`, as can a
handful of other strings in the Customizer JS with singular and plural
forms for which various workarounds have been used.
[attachment:"42140.diff"] contains these updates.
For backcompat, I opted to leave unchanged the affected strings in PHP
that have been localized into JS object properties until now. It seemed
safe to switch `%s theme` string originally in question here to use
`_n()`, though, for consistency with the JS translation.
I'm adding this to the 5.4 milestone in the hope that it can be a
relatively quick improvement!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42140#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list