[wp-trac] [WordPress Trac] #48522: Attachment size not generated when large images uploaded

[WordPress Trac]

#48522: Attachment size not generated when large images uploaded
-------------------------------------------------+-------------------------
 Reporter:  vanyukov                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.3.1
Component:  Media                                |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  2nd-opinion has-patch needs-testing  |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Looking at 48522.diff again, it changes the behaviour in
 `_wp_make_subsizes()`. Until now errors while creating a particular sub-
 size were silently ignored. As the sub-sizes are created in a loop, that
 allowed the loop to continue and (attempt to) create the next sub-size.

 The change in behaviour makes sense while post-processing uploaded images,
 but may be unexpected when "recreating thumbnails", etc. Arguably when one
 sub-size fails, the whole "operation" should fail too however throwing a
 PHP error and exiting will prevent any follow-up handling. Working on a
 revised patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48522#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform