[wp-trac] [WordPress Trac] #40044: A little strange logic in get_header_video_url() function

WordPress Trac noreply at wordpress.org
Wed Nov 27 20:53:49 UTC 2019


#40044: A little strange logic in get_header_video_url() function
-------------------------+------------------------------
 Reporter:  Tkama        |       Owner:  SergeyBiryukov
     Type:  enhancement  |      Status:  reviewing
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Customize    |     Version:  4.7
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------
Changes (by dlh):

 * keywords:  needs-patch => has-patch
 * milestone:  5.4 => Awaiting Review


Comment:

 [attachment:"40044.diff"] attempts to fix the unnecessary call to
 `get_theme_mod()` when there's a `header_video` ID. It also removes the
 early escaping on the value for the reason mentioned in comment:3, but,
 again, that might be a misunderstanding.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40044#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list