[wp-trac] [WordPress Trac] #48817: do_action_deprecated and apply_filters_deprecated $replacement param should default to null

WordPress Trac noreply at wordpress.org
Wed Nov 27 20:25:55 UTC 2019


#48817: do_action_deprecated and apply_filters_deprecated $replacement param should
default to null
-----------------------------------------------------+---------------------
 Reporter:  felipeelia                               |       Owner:  (none)
     Type:  defect (bug)                             |      Status:  new
 Priority:  normal                                   |   Milestone:  5.4
Component:  Plugins                                  |     Version:
 Severity:  normal                                   |  Resolution:
 Keywords:  good-first-bug needs-patch dev-feedback  |     Focuses:
-----------------------------------------------------+---------------------
Changes (by shaampk1):

 * keywords:  good-first-bug needs-patch => good-first-bug needs-patch dev-
     feedback


Comment:

 Replying to [ticket:48817 felipeelia]:
 > `_deprecated_hook`, the function responsible for logging an error when
 an old hook is called, uses `is_null` to check if a `$replacement` was
 provided.
 >
 > The problem is that `$replacement` defaults to `false` (instead of
 `null`) on `apply_filters_deprecated` and `do_action_deprecated`,
 displaying the `Use %3$s instead.'` message without any value.

 Hi,

 This ticket looks interesting. Can you please provide any screenshot or
 the hook that is causing the issue?

 Thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48817#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list