[wp-trac] [WordPress Trac] #48409: Menus: form controls disabled only visually when creating a new menu
WordPress Trac
noreply at wordpress.org
Tue Nov 26 15:06:22 UTC 2019
#48409: Menus: form controls disabled only visually when creating a new menu
----------------------------------------------+----------------------------
Reporter: afercia | Owner: audrasjb
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.3.1
Component: Menus | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch commit | Focuses: ui,
| accessibility
----------------------------------------------+----------------------------
Comment (by SergeyBiryukov):
Replying to [ticket:48409 afercia]:
> All the checkboxes and input fields could use a `disabled` HTML
attribute but it should be set via JavaScript and the implementation looks
a bit overkill at a first glance.
Just noting that we already have `wp_nav_menu_disabled_check()` for
disabling "Add to Menu" submit buttons there, so disabling all the other
checkboxes and input fields seems as simple as
[attachment:"48409.2.diff"].
Would that solve the issues here, except for accordions and tabs still
being clickable?
If that still causes confusion or doesn't address all the issues, then I
have no objections to [attachment:"48409.1.diff"], other than leaving a
weird empty space on the left, but that seems like a fair compromise.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48409#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list