[wp-trac] [WordPress Trac] #42274: preview_sidebars_widgets unsetting $sidebars_widgets['array_version'] without check

WordPress Trac noreply at wordpress.org
Mon Nov 25 03:00:47 UTC 2019


#42274: preview_sidebars_widgets unsetting $sidebars_widgets['array_version']
without check
-------------------------------+----------------------
 Reporter:  darrencoutts       |       Owner:  (none)
     Type:  defect (bug)       |      Status:  closed
 Priority:  normal             |   Milestone:
Component:  Customize          |     Version:  3.9
 Severity:  normal             |  Resolution:  wontfix
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+----------------------
Changes (by dlh):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 Closing for lack of feedback. Additionally, `unset()` is safe to use even
 when the array key does not exist.

 As for ensuring the method returns an array: The method already does due
 diligence by passing `array()` as the fallback to `get_option()`. Any
 additional database corruption would affect more than the Customizer, I
 think.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42274#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list