[wp-trac] [WordPress Trac] #48605: add_magic_quotes() inappropriately recasts data types

[WordPress Trac]

#48605: add_magic_quotes() inappropriately recasts data types
--------------------------+-----------------------------
 Reporter:  Veraxus       |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  5.4
Component:  General       |     Version:  trunk
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------

Comment (by jrf):

 I've replaced the original first patch as it only addressed
 `$_SERVER['REQUEST_TIME']` and `$_SERVER['REQUEST_TIME_FLOAT']` should
 also be fixed. Includes adding some inline documentation about the change.

 The second patch already handles that correctly.

 Similar to before:
 * I've confirmed that `$_SERVER['REQUEST_TIME_FLOAT']` is not used in WP
 Core itself.
 * I've searched the plugins and themes and looked through the code of a
 number of usage instances and my findings are the same as for
 `$_SERVER['REQUEST_TIME']`: the type change to the expected type should
 not cause any issues.

 Plugins: https://wpdirectory.net/search/01DTAEJ2SGSEMWPRQ1S0XK31X3
 Themes: https://wpdirectory.net/search/01DTAEJ8787G6624VA1VQMFD0S

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48605#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform