[wp-trac] [WordPress Trac] #48633: Twenty Twenty theme may be requires attached patch coding changes.

WordPress Trac noreply at wordpress.org
Fri Nov 22 08:59:52 UTC 2019


#48633: Twenty Twenty theme may be requires attached patch coding changes.
---------------------------+----------------------
 Reporter:  chintan1896    |       Owner:  (none)
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:  invalid
 Keywords:                 |     Focuses:
---------------------------+----------------------

Comment (by chintan1896):

 @Otto42

 Please check this variable scope in theme. We don't need use this variable
 because this variable has null throughout theme.
 {{{
 $post_meta_classes
 }}}

 I follow latest WordPress theme for coding standards but /wp-
 content/themes/twentytwenty/template-parts/entry-header.php in this file
 have two static variables one variable was escaped and one variable was
 not escaped.
 {{{

 <header class="entry-header has-text-align-center<?php echo esc_attr(
 $entry_header_classes ); ?>">

 <div class="intro-text section-inner max-percentage<?php echo
 $intro_text_width; //phpcs:ignore
 WordPress.Security.EscapeOutput.OutputNotEscaped -- static output ?>">
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48633#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list