[wp-trac] [WordPress Trac] #48333: Show success notice when the admin verification screen is "snoozed"

[WordPress Trac]

#48333: Show success notice when the admin verification screen is "snoozed"
-----------------------------------+---------------------------------
 Reporter:  desrosj                |       Owner:  whyisjake
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  5.3.1
Component:  Site Health            |     Version:  5.3
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  ui, administration
-----------------------------------+---------------------------------
Changes (by azaozz):

 * keywords:  has-patch => has-patch 2nd-opinion


Comment:

 Looking at 48333.diff the problem with this approach is that the query
 string may get "sticky" in some cases and then the message will be
 displayed "out of bounds" which will make it confusing.

 For example if the user is redirected to a (plugin) screen that has a
 `<form action="">`, the query string will "carry over" after submitting
 that form and the message will be displayed again. Another edge case is
 making a browser bookmark when the query string is present. Then every
 time the bookmark is used, the same message will be displayed...

 This was in the initial patch but was removed for that reason.

 Another possible solution would be to set a transient when that message is
 needed, and remove it when the message is displayed. However that writes
 to the DB, twice. Still probably a better approach as these DB writes will
 only happen for logged-in users.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48333#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform