[wp-trac] [WordPress Trac] #48648: Inconsistent length of .action-links DIV in plugin card
WordPress Trac
noreply at wordpress.org
Wed Nov 20 16:32:34 UTC 2019
#48648: Inconsistent length of .action-links DIV in plugin card
-------------------------------------------------+-------------------------
Reporter: kharisblank | Owner:
| SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.4
Component: Plugins | Version: 5.3
Severity: normal | Resolution:
Keywords: has-screenshots good-first-bug has- | Focuses: ui,
patch | administration
-------------------------------------------------+-------------------------
Comment (by sabernhardt):
Replying to [comment:6 kharisblank]:
The patch isn't weak; it simply might be improved in some way :)
> If ellipsis would make it worse, all translators should correct and use
shorter text.
Hiding text overflow would make it worse, though. For example, if the word
for "Now" happens to come first in a translation for "Activate Now" or
"Update Now", the more important word could be hidden/truncated. Trimming
the overflow would also trim any links that are 121-140 pixels wide;
however, extending into the padding area within the border should be
acceptable. Since I only noticed a significant overflow there for a few
languages' "Update Now" links, I would lean toward editing that text
instead of the CSS. Doing that would be outside the scope of this ticket,
so **let's leave that** discussion for another ticket.
I still would like to increase the right margin of the name and
description containers (perhaps an arbitrary 130px) to make sure there is
a small gap between them and the action links. If anyone thinks adding a
gap makes the name and description containers too narrow at certain screen
sizes, I support committing the first patch as it is.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48648#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list