[wp-trac] [WordPress Trac] #48648: Inconsistent length of .action-links DIV in plugin card

[WordPress Trac]

#48648: Inconsistent length of .action-links DIV in plugin card
-------------------------------------------------+-------------------------
 Reporter:  kharisblank                          |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.4
Component:  Plugins                              |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots good-first-bug has-  |     Focuses:  ui,
  patch                                          |  administration
-------------------------------------------------+-------------------------

Comment (by sabernhardt):

 Thanks @kharisblank for the patch! I tested it at various browser widths
 in Firefox, Chrome, Edge and Internet Explorer (all on Windows 10). That
 patch successfully makes the "More Details" links a consistent width
 throughout the Plugins page in each language.

 This patch also keeps the primary action link from overlapping the Plugin
 Name, as can happen with some languages in WordPress 5.2 and 5.3. The
 widest links I noticed include the "Update Now" links in French, Malayalam
 and Tamil. With the patch, wider links extend beyond the "More Details"
 link instead (in some cases, outside the card and perhaps even off
 screen). So we can consider adding a comment for translators, which would
 recommend shorter length.

 We also could reconsider the 120px width of the `action-links` container.
 The 2em side margin does not affect screen sizes where that container is
 positioned in the 120px right margin of the Name and Description
 containers. The "More Details" link in Upper Sorbian nearly touches the
 plugin description, and it is possible to get closer in another language.
 {{{
 .plugin-card .name,
 .plugin-card .desc {
     margin-left: 148px;
     margin-right: 120px;
 }
 }}}

 And maybe the discussion of additional changes belongs on a separate
 ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48648#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform