[wp-trac] [WordPress Trac] #46418: Use wp_die() instead of die() function in wordpress

Mon Nov 18 04:24:19 UTC 2019

#46418: Use wp_die() instead of die() function in wordpress
------------------------------+-----------------------------
 Reporter:  immeet94          |       Owner:  SergeyBiryukov
     Type:  enhancement       |      Status:  reviewing
 Priority:  normal            |   Milestone:  5.4
Component:  Administration    |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------

Comment (by garrett-eclipse):

 With [https://core.trac.wordpress.org/changeset/46739 r46739] updating the
 version being committed (thanks @SergeyBiryukov) I've updated the patch in
 [https://core.trac.wordpress.org/attachment/ticket/46418/48676.4.diff
 48676.4.diff].

 While looking at this I wonder what other instances of die in core should
 become wp_die;
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 activate.php#L18 wp-activate.php line#18]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /admin-footer.php#L11 wp-admin/admin-footer.php line#11]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /async-upload.php#L34 wp-admin/async-upload.php line#34]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 admin/comment.php#L95-L106 wp-admin/comment.php lines#95,100,106]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /edit-form-advanced.php#L11 wp-admin/edit-form-advanced.php line#11]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /edit-form-blocks.php#L13 wp-admin/edit-form-blocks.php line#13]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /edit-form-comment.php#L11 wp-admin/edit-form-comment.php line#11]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /edit-link-form.php#L11 wp-admin/edit-link-form.php line#11]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /edit-tag-form.php#L11 wp-admin/edit-tag-form.php line#11]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 admin/export.php#L122 wp-admin/export.php line#122]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 admin/includes/class-pclzip.php#L221 wp-admin/includes/class-pclzip.php
 line#221]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 admin/includes/class-wp-site-health.php#L196 wp-admin/includes/class-wp-
 site-health.php line#196]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 admin/includes/image-edit.php#L28 wp-admin/includes/image-edit.php
 line#28]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 admin/includes/network.php#L120-L148 wp-admin/includes/network.php
 lines#120,133,148]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 admin/install.php#L217-L289 wp-admin/install.php lines#217,264,269,282]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /link-parse-opml.php#L10 wp-admin/link-parse-opml.php line#10]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 admin/upgrade.php#L35 wp-admin/upgrade.php line#35]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /user-edit.php#L109-L117 wp-admin/user-edit.php lines#109,117]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-admin
 /user-new.php#L44-L217 wp-admin/user-new.php lines#44,50,150,174,217]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 cron.php#L32-L152 wp-cron.php lines#32,81,152]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 includes/canonical.php#L349-L611 wp-includes/canonical.php
 lines#349,394,611]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-includes
 /class-simplepie.php#L665 wp-includes/class-simplepie.php line#665]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-includes
 /class-wp-ajax-response.php#L160 wp-includes/class-wp-ajax-response.php
 line#160]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-includes
 /class-wp-widget.php#L113 wp-includes/class-wp-widget.php line#113]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 includes/comment.php#L716-L930 wp-includes/comment.php line#716,930]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 includes/embed.php#L728 wp-includes/embed.php line#728]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 includes/functions.php wp-includes/functions.php
 lines#3419,3459,3499,3541,3573,3617,3639,3641,4513]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 includes/IXR/class-IXR-server.php#L47 wp-includes/IXR/class-IXR-server.php
 line#47]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 includes/load.php wp-includes/load.php lines#35,219,614,1449]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-includes
 /ms-deprecated.php wp-includes/ms-deprecated.php lines#116,615]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-includes
 /ms-files.php#L15-L30 wp-includes/ms-files.php lines#15,24,30]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 includes/pluggable.php#L1130-L1184 wp-includes/pluggable.php
 lines#1130,1184]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-includes
 /rest-api.php#L308 wp-includes/rest-api.php line#308]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-includes
 /theme-compat/comments.php#L20 wp-includes/theme-compat/comments.php
 line#20]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-includes
 /wp-db.php#L1678 wp-includes/wp-db.php line#1678]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 settings.php#L530 wp-settings.php line#530]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 signup.php wp-signup.php lines#14,34,39,412]
 [https://github.com/WordPress/wordpress-develop/blob/5.3.0/src/wp-
 trackback.php#L35 wp-trackback.php line#35]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46418#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform