[wp-trac] [WordPress Trac] #48467: Update broken library links in PHP docblocks
WordPress Trac
noreply at wordpress.org
Sun Nov 17 16:00:54 UTC 2019
#48467: Update broken library links in PHP docblocks
--------------------------------------+-----------------------------
Reporter: mryoga | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses: docs
--------------------------------------+-----------------------------
Comment (by SergeyBiryukov):
Replying to [comment:7 FinchPS]:
> This patch addresses only the PHP files linked in the original Github PR
here: https://github.com/WordPress/WordPress/pull/441
>
> For the other files, these should be changed upstream in the original
repos. I'll go ahead and submit PRs to those as well, and update this
ticket with those links as well. As they are accepted, they will update WP
Core on subsequent builds.
Thanks for the patch! Just noting that PHPMailer is an external library
too.
Looking at the original PR, only these files can be patched directly:
{{{
wp-admin/includes/class-wp-filesystem-ssh2.php
js/_enqueues/vendor/imgareaselect/jquery.imgareaselect.js
}}}
`jquery.imgareaselect.js` used to be an external library, but appears to
be abandoned upstream and is treated as "adopted" in WordPress core.
Any changes to other libraries and components from the initial pull
request should be submitted to the respective GitHub repositories:
* https://github.com/PHPMailer/PHPMailer
* https://github.com/zenorocha/clipboard.js
* https://github.com/WordPress/gutenberg/tree/master/packages/blocks
* https://github.com/WordPress/gutenberg/tree/master/packages/components
* https://github.com/babel/babel/tree/master/packages/babel-polyfill
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48467#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list