[wp-trac] [WordPress Trac] #48117: onclick attribute is not properly escaped in the _render_item method of WP_Admin_Bar class.

WordPress Trac noreply at wordpress.org
Fri Nov 15 23:22:31 UTC 2019


#48117: onclick attribute is not properly escaped in the _render_item method of
WP_Admin_Bar class.
------------------------------+------------------------
 Reporter:  tmatsuur          |       Owner:  whyisjake
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  5.4
Component:  Toolbar           |     Version:  5.2.3
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------------
Changes (by whyisjake):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"46734" 46734]:
 {{{
 #!CommitTicketReference repository="" revision="46734"
 Toolbar: Properly escape the onclick attribute.

 The onclick attribute was being escaped twice, once with `esc_js` and
 again with `esc_attr`.

 Fixes #48117.
 Props tmatsuur, dinhtungdu.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48117#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list