[wp-trac] [WordPress Trac] #31245: Replace alloptions with a key cache

[WordPress Trac]

#31245: Replace alloptions with a key cache
-------------------------------------+--------------------------
 Reporter:  rmccue                   |       Owner:  tellyworth
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.4
Component:  Options, Meta APIs       |     Version:  2.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+--------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:87 tellyworth]:
 > What are the blockers for getting attachment:31245.3.diff into trunk?
 >
 > I'm not thrilled that it removes tests.

 Per discussion starting with comment:82, [attachment:"31245.4.diff"] would
 be cleaner way of implementing it, allowing existing object caches to
 choose whether to go with core's `wp_cache_delete( 'alloptions', 'options'
 )` or unhook it and keep their own implementation for better performance.

 However, I'm leaning towards [attachment:"31245.4.fabian-race-fix.diff"]
 (a refresh of [attachment:"fabian-race-fix.diff"]). Per comment:83, it
 appears to be the safest option here that will have an impact while also
 reducing the side effects. It also doesn't need to remove any tests, the
 full suite seems to pass as is with the patch applied.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/31245#comment:88>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform