[wp-trac] [WordPress Trac] #48626: Twenty Twenty: Remove unused function argument (was: Remove unused function argument)
WordPress Trac
noreply at wordpress.org
Thu Nov 14 11:13:19 UTC 2019
#48626: Twenty Twenty: Remove unused function argument
---------------------------+------------------------------
Reporter: manikmist09 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version: 5.3
Severity: normal | Resolution:
Keywords: has-patch | Focuses: template
---------------------------+------------------------------
Comment (by nielslange):
@manikmist09 The Twenty Twenty theme uses the filter `add_filter(
'edit_post_link', 'twentytwenty_edit_post_link', 10, 3 );`. Removing
`$text` from `twentytwenty_edit_post_link( $link, $post_id, $text )` would
lead to the fact that only the translation can be controlled but not the
logic, in case a developer wants to allow additional HTML elements and/or
attributes.
@Anlino and @williampatton Please correct me if I'm wrong.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48626#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list