[wp-trac] [WordPress Trac] #48588: Unable to Replace Image in Image widget is using "Insert from URL"

WordPress Trac noreply at wordpress.org
Wed Nov 13 14:43:45 UTC 2019


#48588: Unable to Replace Image in Image widget is using "Insert from URL"
----------------------------+------------------------
 Reporter:  dufresnesteven  |       Owner:  audrasjb
     Type:  defect (bug)    |      Status:  reviewing
 Priority:  normal          |   Milestone:  5.3.1
Component:  Widgets         |     Version:  5.3
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+------------------------
Changes (by afercia):

 * keywords:   => needs-patch
 * milestone:  Awaiting Review => 5.3.1


Comment:

 I think this happens after [45499].

 A possible fix would be changing `view.url.focus()` to
 `view.url.input.focus()`.

 However, it is preferable to not move focus in the first place, as that's
 an assumption on a user flow that may not be the intended one. See #43169.

 I'd lean towards removing the code responsible for moving focus from
 `src/js/_enqueues/wp/widgets/media.js`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48588#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list