[wp-trac] [WordPress Trac] #48597: class-wp-upgrader-skin.php 5.3 update

WordPress Trac noreply at wordpress.org
Wed Nov 13 12:01:24 UTC 2019


#48597: class-wp-upgrader-skin.php 5.3 update
--------------------------+-----------------------------
 Reporter:  jlchapmanbg   |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 On line 145 the public function 'feedback' broke my site - I am using
 Ocean wp and and got errors and headers already sent due to the addition
 of ', ...$args' to the function declaration.
 Warning: Declaration of QuietSkin::feedback($string) should be compatible
 with WP_Upgrader_Skin::feedback($string, ...$args) in
 /home/expatu5/public_html/wp-content/plugins/ocean-
 extra/includes/wizard/classes/QuietSkin.php on line 12
 I have removed this from the code and all is back working.
 This seems to be an oversight as '...$args' is the not to my understanding
 the correct way to declare args.
 If I am incorrect please let me know how I should address this problem.
 Regards.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48597>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list