[wp-trac] [WordPress Trac] #48573: Permalinks Settings screen unnecessarily calls sanitize_option( 'permalink_structure' )...

[WordPress Trac]

#48573: Permalinks Settings screen unnecessarily calls sanitize_option(
'permalink_structure' )...
--------------------------------+------------------------------
 Reporter:  pbiron              |       Owner:  (none)
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Options, Meta APIs  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  2nd-opinion         |     Focuses:
--------------------------------+------------------------------
Changes (by pbiron):

 * keywords:   => 2nd-opinion


Comment:

 If it really is necessary for the Permalink Setting screen to sanitize the
 new value before calling `WP_Rewrite::set_permalink_structure()`, then
 shouldn't it also sanitize `$category_base` and `$tag_base` before calling
 `WP_Rewrite::set_[category|tag]_base()`?

 I'll do a patch either way (i.e., removing the unnecessary call or adding
 the 2 missing calls) as soon as others confirm which way to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48573#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform